Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add avatar_url field to RepoStatus #2021

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Conversation

noahingh
Copy link
Contributor

I've added the AvatarURL field to RepoStatus to bind the avatar_url field from the response. Thanks.

> Github document (combined status)

@google-cla
Copy link

google-cla bot commented Jul 26, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jul 26, 2021
@noahingh
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Jul 26, 2021
@gmlewis gmlewis changed the title feat: add avatar_url field to combined status Add avatar_url field to RepoStatus Jul 26, 2021
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @hanjunlee !
Please run go generate ./... and push (not force-push) the changes to this PR.

This is covered in our CONTRIBUTING.md document in the top of the repo.

@noahingh noahingh requested a review from gmlewis July 26, 2021 07:29
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #2021 (ba34b51) into master (a12f9cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2021   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files         107      107           
  Lines        6901     6901           
=======================================
  Hits         6754     6754           
  Misses         81       81           
  Partials       66       66           
Impacted Files Coverage Δ
github/repos_statuses.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a12f9cd...ba34b51. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @hanjunlee !
LGTM.
Merging.

@gmlewis gmlewis merged commit ac48d59 into google:master Jul 26, 2021
@noahingh noahingh deleted the feat/avatar-url branch July 26, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants