Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add struct for workflow_job event #2038

Merged
merged 3 commits into from Sep 3, 2021
Merged

Add struct for workflow_job event #2038

merged 3 commits into from Sep 3, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2021

This is a new (as of now undocumented) event that has been darkshipped by GitHub.

It provides three actions: queued, started and completed, reusing the existing WorkflowJob struct.

Official documentation is supposedly soon to follow, but advance submission of this PR has been approved by GitHub staff.

You can hold up this PR until it drops. I will update it accordingly.

@google-cla
Copy link

google-cla bot commented Aug 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 11, 2021
@ghost
Copy link
Author

ghost commented Aug 11, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Aug 11, 2021
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #2038 (3de6833) into master (95b92df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2038   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files         107      107           
  Lines        6907     6909    +2     
=======================================
+ Hits         6760     6762    +2     
  Misses         81       81           
  Partials       66       66           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)
github/messages.go 100.00% <ø> (ø)
github/event.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b92df...3de6833. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @acuteaura !
Could you please also add this new event to ParsePayload and also a couple more places? If you search for WorkflowRunEvent then you should be able to find the other locations.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you, @acuteaura !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp August 11, 2021 17:04
Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 3, 2021

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit bbd5d19 into google:master Sep 3, 2021
@ghost ghost deleted the event-workflow_job branch September 7, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants