Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci) : cache go-build folders #2054

Merged
merged 4 commits into from
Aug 19, 2021
Merged

chore(ci) : cache go-build folders #2054

merged 4 commits into from
Aug 19, 2021

Conversation

mmorel-35
Copy link
Contributor

Signed-off-by: Matthieu MOREL mmorel-35@users.noreply.github.com

@mmorel-35
chore(ci) : cache go-build folders
7721122 
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Aug 19, 2021
@mmorel-35 mmorel-35 mentioned this pull request Aug 19, 2021
Closed
@codecov
Copy link

codecov bot commented Aug 19, 2021 •
edited

Codecov Report

Merging #2054 (8590601) into master (c3073c8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2054   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files         107      107           
  Lines        6907     6907           
=======================================
  Hits         6760     6760           
  Misses         81       81           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3073c8...8590601. Read the comment docs.

@willnorris
Copy link
Collaborator

Here's an interesting cross platform approach that uses the output of got env GOCACHE and go env GOMODCACHE: https://markphelps.me/2019/11/speed-up-your-go-builds-with-actions-cache/

what do you think? he has it split into two separate cache steps, but I'm not sure that' necessary, since they're both using the hash of **/go.sum for the cache key.

willnorris
willnorris reviewed Aug 19, 2021
View reviewed changes
.github/workflows/tests.yml Outdated

# Get values for cache paths to be used in later steps
- id: go-cache
run: echo "::set-output name=go-build::$(go env GOCACHE)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well use this approach for go env GOMODCACHE too? I mean, it's not likely to change, but you never know and the consistency is nice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@willnorris
Copy link
Collaborator

sweet, thanks! I'll let these latest round of tests finish running then merge.

@willnorris willnorris merged commit 02c7be3 into google:master Aug 19, 2021
@gmlewis gmlewis mentioned this pull request Sep 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willnorris willnorris willnorris left review comments

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmorel-35 @willnorris