Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape package names to support names which include a slash #3002

Merged
merged 6 commits into from
Dec 16, 2023
Merged

Escape package names to support names which include a slash #3002

merged 6 commits into from
Dec 16, 2023

Commits on Dec 1, 2023

  1. Escape package names to support names which include a slash

    @bn4t
    Benjamin Nater authored and bn4t committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    5ecb48f View commit details
    Browse the repository at this point in the history

  2. Add comment detailing that the package name is automatically escaped

    @bn4t
    Benjamin Nater authored and bn4t committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    8cc816b View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Escape the package name for DeletePackage

    Benjamin Nater committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    c69e0e4 View commit details
    Browse the repository at this point in the history

  2. Modify tests to test for package names with slashes 

    Changed fmt.Fprint to io.WriteString because go vet complained about possible Printf formatting directive.
    Benjamin Nater committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    34c4961 View commit details
    Browse the repository at this point in the history

  3. run ./script/generate.sh

    Benjamin Nater committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    aeebc20 View commit details
    Browse the repository at this point in the history

  4. handle errors of io.WriteString in test functions

    Benjamin Nater committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    5a5a215 View commit details
    Browse the repository at this point in the history