Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Propagate context with DownloadContents #3181

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

HakShak
Copy link
Contributor

@HakShak HakShak commented Jun 9, 2024

Main motivation is tracing as this can be the most time consuming operation.

Main motivation is tracing as this can be the most time consuming
operation.
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.90%. Comparing base (2b8c7fa) to head (c29514f).
Report is 67 commits behind head on master.

Files Patch % Lines
github/repos_contents.go 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3181      +/-   ##
==========================================
- Coverage   97.72%   92.90%   -4.82%     
==========================================
  Files         153      171      +18     
  Lines       13390    11548    -1842     
==========================================
- Hits        13085    10729    -2356     
- Misses        215      726     +511     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis changed the title fix: propagate context with DownloadContents Fix: Propagate context with DownloadContents Jun 9, 2024
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 9, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @HakShak !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@tomfeigin tomfeigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jun 11, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Jun 11, 2024

Thank you, @tomfeigin !
Merging.

@gmlewis gmlewis merged commit f78378d into google:master Jun 11, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants