-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added git tags support. #51
Conversation
"fmt" | ||
) | ||
|
||
// Object represents a git object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's my background in Java, but having a type simply named "Object" makes me nervous :) I'm not sure if we'll see conflicts later on, but how about calling it TagObject
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind... ignore this. I see that "object" is actually used in several places throughout the API, and fortunately they're all consistent. So simply calling this Object
should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I don't feel great about it being Object. What do you think about GitObject?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that's probably better.
How does that look? It's been a while! |
rebased onto master, cleaned up a little and merged as 4fe63c8 just as FYI, the cleanup I did was to switch struct fields to pointers, and to make it so |
Added API calls for http://developer.github.com/v3/git/tags/.