Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added git tags support. #51

Closed
wants to merge 3 commits into from
Closed

Added git tags support. #51

wants to merge 3 commits into from

Conversation

sww
Copy link
Contributor

@sww sww commented Aug 27, 2013

"fmt"
)

// Object represents a git object.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's my background in Java, but having a type simply named "Object" makes me nervous :) I'm not sure if we'll see conflicts later on, but how about calling it TagObject?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind... ignore this. I see that "object" is actually used in several places throughout the API, and fortunately they're all consistent. So simply calling this Object should be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I don't feel great about it being Object. What do you think about GitObject?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's probably better.

@tchap tchap mentioned this pull request Nov 21, 2013
@sww
Copy link
Contributor Author

sww commented Feb 14, 2014

How does that look? It's been a while!

@willnorris
Copy link
Collaborator

rebased onto master, cleaned up a little and merged as 4fe63c8

just as FYI, the cleanup I did was to switch struct fields to pointers, and to make it so CreateTag can actually take a Tag as input rather than a TagRequest. It still gets converted into a TagRequest (though that's no longer exported and I renamed it to createTagRequest), but that happens transparently to the caller now. Not sure why I didn't consider doing it that way when I first reviewed this.

@willnorris willnorris closed this Apr 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants