Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ListPendingOrgInvitations method to take string org name. #731

Merged
merged 1 commit into from Oct 3, 2017

Conversation

dmitshur
Copy link
Member

The /orgs/:org GitHub API endpoint expects the string name of the organization, not its integer ID (that would be /organizations/:id endpoint, which we're generally not using).

Change the org parameter type from int to string to make it possible to specify the organization via its name.

This method wasn't functional before.

Fixes #730.

The /orgs/:org GitHub API endpoint expects the string name of the
organization, not its integer ID (that would be /organizations/:id
endpoint, which we're generally not using).

Change the org parameter type from int to string to make it possible to
specify the organization via its name.

This method wasn't functional before.

Fixes #730.
@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Sep 27, 2017
Copy link
Contributor

@elliott-beach elliott-beach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I imagine the mistake originally occurred by copying the signature from ListPendingTeamInvitations, which takes an id for the team. org is a string in all other usages.

@dmitshur
Copy link
Member Author

dmitshur commented Oct 3, 2017

Friendly ping @gmlewis, are you able to review this? Someone sent a duplicate PR #738.

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 3, 2017

Sorry for the delay... reviewing...

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.
Thank you, @shurcooL and @e-beach!

@gmlewis gmlewis merged commit 066c8ed into master Oct 3, 2017
@dmitshur dmitshur deleted the fix-730 branch October 3, 2017 18:03
nbareil pushed a commit to nbareil/go-github that referenced this pull request May 1, 2018
…gle#731)

The /orgs/:org GitHub API endpoint expects the string name of the
organization, not its integer ID (that would be /organizations/:id
endpoint, which we're generally not using).

Change the org parameter type from int to string to make it possible to
specify the organization via its name.

This method wasn't functional before.

Fixes google#730.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants