Support MarketeplacePurchaseEvent

[scriptonist]

Fixes #785

[dmitshur]

We don't use time.Time directly in go-github, we have a custom Timestamp type defined that handles some inconsistencies in time formatting on GitHub API side:

We should use it here, primarily for consistency. For example, see:

go-github/github/event_types.go

Lines 583 to 585 in 471e67c

	CreatedAt *Timestamp `json:"created_at,omitempty"`
	PushedAt *Timestamp `json:"pushed_at,omitempty"`
	UpdatedAt *Timestamp `json:"updated_at,omitempty"`

go-github/github/event_types.go

Lines 670 to 671 in 471e67c

	CreatedAt *Timestamp `json:"created_at,omitempty"`
	UpdatedAt *Timestamp `json:"updated_at,omitempty"`

[dmitshur]

You'll need to break the fields into two sections. The event API payload fields (of which, there's only one, action):

And Webhook payload fields, which are all the rest. You should put them under a // The following fields are only populated by Webhook events. comment. Something like this:

type MarketplacePurchaseEvent struct {
	// Action is the action that was performed. Possible values are:
	// "purchased", "cancelled", or "changed".
	Action *string `json:"action,omitempty"`

	// The following fields are only populated by Webhook events.
	...
}

See structs right above and below the one you added for reference.

[dmitshur]

Additionally, you'll need to add an implicit Installation *Installation `json:"installation,omitempty"` field. Its existence is documented at https://developer.github.com/webhooks/#payloads. Put it at the very bottom; see other events in this file as reference.

[scriptonist]

Okay @shurcooL, will fix these. thanks 👍 .

[dmitshur]

The 3 fields above are missing ,omitempty suffix. The rest of the fields have it.

You should add them for consistency (unless there's a good reason not to include them; I don't know of any, let me know if you do).

[dmitshur]

The CI is failing on the latest commit. It looks like you'll need to regenerate the package with go generate again.

[scriptonist]

@shurcooL It looks good right ?

[dmitshur]

LGTM. Thanks @scriptonist!

I can apply the minor comment myself and merge.

[dmitshur]

It'd be nice to add a comment here documenting possible action values, like in the events above and below.

// Action is the action that was performed. Possible values are:
// "purchased", "cancelled", "changed".

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.