New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove preview media type for Team Review Requests #844
Conversation
As the Team Review Requests API is fully supported by GitHub API v3, we have removed the preview(custom) media type: thor-preview. Closes google#840
Re: question 1: GitHub Enterprise customers must now pin specific tagged releases of this package and we can move forward without hesitation due to #376. Re: question 2: According to our new versioning strategy, the tagged minor version would be bumped in this case. |
Yes, I meant to refer #835 instead of #840. Thanks for pointing this out. |
I think you can simply edit that first message. A force push should not be necessary because I can make sure the commit message has the right text when merging... as long as I remember to do that correctly. 😄 |
Sure! That's awesome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you, @kshitij10496!
I'll let this sit for a day in case there are any other comments, then merge tomorrow (unless another reviewer LGTM's and merges before then). Feel free to ping me if I forget to merge tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
This makes sense. |
I think it is a good idea in general to wait for comments/conversation on a PR, but am not sure that we need to formalize it. Sometimes there are good reasons to merge things ASAP... I think it might keep things a bit more flexible if we leave it up to the maintainers of the repo to decide on a PR-by-PR basis. |
Sorry for the delay... Merging. |
As the Team Review Requests API is fully supported by GitHub API v3, we have removed the preview(custom) media type: thor-preview. Fixes google#840.
As the Team Review Requests API is fully supported by GitHub API v3, we
have removed the preview(custom) media type:
thor-preview
.Fixes #835
Ping @willnorris @gmlewis @sahildua2305