Add ListContributorsStats and ListCommitActivity for RepositoriesService #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,72 @@ | |||
| // Copyright 2013 The go-github AUTHORS. All rights reserved. | |||
There was a problem hiding this comment.
go ahead and use the current year in newly created files
|
I think all my comments are exclusively related to Go style or documentation. Otherwise, this looks great. |
|
Regarding the 202 vs 200 response, I think you did the right thing in the code here, namely leaving it to the caller to handle. Maybe we should add some documentation that explains that though? |
|
Updated the comments and added comments to the functions about the 202 vs 200 response. I couldn't find anywhere else in the API (it was a quick skim) that used a unix timestamp so I left that alone. |
|
Whoops! Forgot to update test (just did)! |
|
rebased onto master and merged as f9fd615. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you make a request for stats, you often get a 202 back at first (meaning the stats haven't been computed but now will be computed). I didn't do any extra work because I figured the user would rather be the one handling this (once you receive a 202, waiting ~1 second and then making the request again results in a 200).