Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Evaluate functions, to be able to reuse the AST from SnippetToAST #264

Merged
merged 1 commit into from Mar 11, 2019

Conversation

abourget
Copy link
Contributor

@abourget abourget commented Mar 8, 2019

Right now, SnippetToAST provides a Node but nothing consumes it it seems.

This is mostly to open the discussion. My goal is to use jsonnet as a reformatter in streaming objects.. Performance is going to be paramount for us, reusing the AST is a start.

Nice work in here by the way.. love the project :)

…oAST`.

Right now, SnippetToAST provides a `Node` but nothing consumes it it seems.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 75.192% when pulling d994e6e on abourget:master into 530e796 on google:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 75.192% when pulling d994e6e on abourget:master into 530e796 on google:master.

@seh
Copy link
Contributor

seh commented Mar 8, 2019

This looks like it might be related to #126.

@abourget
Copy link
Contributor Author

abourget commented Mar 8, 2019

It is indeed :)

@sparkprime
Copy link
Member

@sbarzowski seems ok to me, how about you?

@sbarzowski
Copy link
Collaborator

LGTM, since we are exposing AST api and evaluation api, I don't see any reason not to expose AST evaluation API :-)

One day, we may want to extend and clean up that API, with efficient support for evaluating multiple file at once, or the same one multiple times with different TLAs - preserving cached values, especially for imported libs.

@sparkprime sparkprime merged commit ce90e53 into google:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants