Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cli argument to set the license archive path #36

Closed
wants to merge 1 commit into from

Conversation

jls5177
Copy link

@jls5177 jls5177 commented Jul 26, 2020

Added "--license_db" argument to override the default archive path
set in the "github.com/google/licenseclassifier" module.

@google-cla
Copy link

google-cla bot commented Jul 26, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Contributor license agreement not signed (https://cla.developers.google.com) label Jul 26, 2020
Added "--license_db" argument to override the default archive path
set in the "github.com/google/licenseclassifier" module.
@google-cla google-cla bot added cla: yes Contributor license agreement signed (https://cla.developers.google.com) and removed cla: no Contributor license agreement not signed (https://cla.developers.google.com) labels Jul 26, 2020
@Bobgy
Copy link
Collaborator

Bobgy commented Apr 13, 2022

With go1.16 embed feature, the license db is now included in the binary. Is there still a need to override the license archive?

I'm closing because this is staling, feel free to discuss further

@Bobgy Bobgy closed this Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor license agreement signed (https://cla.developers.google.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants