Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): vendor go/pkgsite/source package for remote URL discovery #95

Merged
merged 10 commits into from
Jan 21, 2022

Conversation

Bobgy
Copy link
Collaborator

@Bobgy Bobgy commented Dec 31, 2021

Part of #73

I've already verified this module works perfectly for our usecases in following up PRs.

I asked whether pkgsite can move the internal package out, but I got reply that we need to vendor it, golang/go#40477 (comment).

Copy link
Contributor

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this in internal/third_party - we don't want to take on responsibility of maintain this package for others.

v2/third_party/go/pkgsite/README.md Outdated Show resolved Hide resolved
@Bobgy
Copy link
Collaborator Author

Bobgy commented Jan 11, 2022

Hi @wlynch, I updated the PR to

  • move the vendored module to internal
  • vendor tests as well
  • remove unused functions to reduce the size of the vendored files (they reduced a lot)

Note that, I did these in clear and separate commits, each commit does just one thing.

@Bobgy Bobgy requested a review from wlynch January 11, 2022 09:09
@Bobgy Bobgy changed the base branch from v2 to master January 14, 2022 01:03
@Bobgy
Copy link
Collaborator Author

Bobgy commented Jan 14, 2022

Updated to target master branch in root folder.

@wlynch wlynch merged commit e0ca1a7 into google:master Jan 21, 2022
@Bobgy Bobgy deleted the vendor-pkgsite-source branch January 23, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants