Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header parsing tests #10

Merged
merged 25 commits into from Jul 9, 2020
Merged

Header parsing tests #10

merged 25 commits into from Jul 9, 2020

Conversation

mattiasgrenfeldt
Copy link
Contributor

Fixes #5

Includes many different tests.

@mattiasgrenfeldt mattiasgrenfeldt self-assigned this Jul 8, 2020
kele
kele requested changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@kele kele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split out the go.mod and go.sum changes to a separate PR.

kele
kele reviewed Jul 8, 2020
View reviewed changes
tests/requestparsing/basicauth_test.go Outdated Show resolved Hide resolved
tests/requestparsing/basicauth_test.go Outdated Show resolved Hide resolved
tests/requestparsing/basicauth_test.go Outdated Show resolved Hide resolved
tests/requestparsing/basicauth_test.go Outdated Show resolved Hide resolved
tests/requestparsing/contentlengthandtransferencoding_test.go Outdated Show resolved Hide resolved
tests/requestparsing/contentlengthandtransferencoding_test.go Outdated Show resolved Hide resolved
tests/requestparsing/basicauth_test.go Outdated Show resolved Hide resolved
tests/requestparsing/contentlengthandtransferencoding_test.go Outdated Show resolved Hide resolved
tests/requestparsing/header_test.go Outdated Show resolved Hide resolved
tests/requestparsing/basicauth_test.go Outdated Show resolved Hide resolved
bsiegert
bsiegert requested changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@bsiegert bsiegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good otherwise.

tests/requestparsing/README.md Outdated Show resolved Hide resolved
tests/requestparsing/basicauth_test.go Outdated Show resolved Hide resolved
tests/requestparsing/basicauth_test.go Outdated Show resolved Hide resolved
tests/requestparsing/contentlengthandtransferencoding_test.go Show resolved Hide resolved
kele
kele requested changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@kele kele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work! These are just the last few nits. :)

tests/requestparsing/basicauth_test.go Outdated Show resolved Hide resolved
tests/requestparsing/README.md Outdated Show resolved Hide resolved
tests/requestparsing/basicauth_test.go Outdated Show resolved Hide resolved
@kele
Copy link
Collaborator

kele commented Jul 9, 2020

@mattiasgrenfeldt please rebase and resolve the conflicts. I can merge then.

@kele kele added enhancement New feature or request documentation Improvements or additions to documentation and removed enhancement New feature or request labels Jul 9, 2020
@kele
Copy link
Collaborator

kele commented Jul 9, 2020

Great work. :)

@kele kele merged commit 1a8a3c1 into master Jul 9, 2020
@mattiasgrenfeldt mattiasgrenfeldt mentioned this pull request Jul 9, 2020
Merged
@mattiasgrenfeldt mattiasgrenfeldt deleted the grenfeldt-header-tests branch July 14, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsiegert bsiegert bsiegert approved these changes

@kele kele kele approved these changes

@empijei empijei Awaiting requested review from empijei

Assignees

@mattiasgrenfeldt mattiasgrenfeldt

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test and document HTTP request headers parsing by net/http
4 participants
@mattiasgrenfeldt @kele @bsiegert @empijei