Make "copyright" CI action pass #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSD head (as opposed to GNU head, apparently) need the "-n lines" argument *before* the list of files.
This is purely a whitespace change. Part of the copyright header is a line of the form `//<space><tab>URL` Putting spaces before tabs is a mistake from a typographical point of view. gofmt seems to agree and occasionally removes the space when rewriting a file. This makes it impossible to get the "gofmt" and "copyright" linters passing at the same time. Let's fix this for good by removing the extra space across the codebase.
|
I think this will fix #330 for good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is purely a whitespace change.
Part of the copyright header is a line of the form
//<space><tab>URLPutting spaces before tabs is a mistake from a typographical point of view. gofmt seems to agree and occasionally removes the space when rewriting a file. This makes it impossible to get the "gofmt" and "copyright" linters passing at the same time.
Let's fix this for good by removing the extra space across the codebase.