Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate functions to be removed #100

Closed
katexochen opened this issue Jan 17, 2024 · 1 comment · Fixed by #101
Closed

deprecate functions to be removed #100

katexochen opened this issue Jan 17, 2024 · 1 comment · Fixed by #101

Comments

@katexochen
Copy link
Contributor

Last release announced upcoming removal of a set of functions from this module. However, those functions are not marked as deprecated in a way that common Go tooling can detect it.

from https://go.dev/blog/godoc:

To signal that an identifier should not be used, add a paragraph to its doc comment that begins with "Deprecated:" followed by some information about the deprecation.
deeglaze added a commit to deeglaze/go-sev-guest that referenced this issue Jan 17, 2024
@deeglaze
Add Deprecated: notes and add proto helpers.
a02f9ac 
Add Product() as a required method for the quote provider interfaces.
Closes google#100.

Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
@deeglaze deeglaze mentioned this issue Jan 17, 2024
Merged
deeglaze added a commit to deeglaze/go-sev-guest that referenced this issue Jan 17, 2024
@deeglaze
Add Deprecated: notes and add proto helpers.
6b09851 
Add Product() as a required method for the quote provider interfaces.
Closes google#100.

Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
deeglaze added a commit to deeglaze/go-sev-guest that referenced this issue Jan 18, 2024
@deeglaze
Add Deprecated: notes and add proto helpers.
d369ba4 
Add Product() as a required method for the quote provider interfaces.
Closes google#100.

Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
@deeglaze
Copy link
Collaborator

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Deprecated: notes and add proto helpers. deeglaze/go-sev-guest
2 participants
@deeglaze @katexochen