Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating go docs #12

Open
bitcoin-coder-bob opened this issue Oct 30, 2019 · 3 comments
Open

Updating go docs #12

bitcoin-coder-bob opened this issue Oct 30, 2019 · 3 comments

Comments

@bitcoin-coder-bob
Copy link
Contributor

bitcoin-coder-bob commented Oct 30, 2019

The docs should be updated to reflect the most recent compatible version as it appears 1.16 (as stated in the go docs) is no longer supported. The very bottom of the docs references versions but it is inconsistent with the version (1.16) listed in the example at the top of the page. I could make the edits here where it seems to mimic the godocs: https://github.com/google/go-tika/blob/fe9f7a490ac6260631874005f88d091330a109f1/tika/doc.go

I can make a pull request for this change. Worth cross referencing this in this issue: #7

@bitcoin-coder-bob bitcoin-coder-bob changed the title Server hanging on start Updating go docs Oct 30, 2019
@tbpg
Copy link
Member

tbpg commented Oct 31, 2019

A PR for that would be awesome. Thanks!

Any other details about the hanging? Did you figure out what was causing it?

@nathj07
Copy link
Contributor

nathj07 commented Apr 1, 2022

I encountered a similar need to update docs. I did not see this issue, sorry about that. I've opened the following PR: #35, not sure why the lint and test are not completing.

@tbpg
Copy link
Member

tbpg commented Apr 1, 2022

First time contributors need a maintainer to click "run." I left a review, then would be happy to merge. Thanks for the PR. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants