Update server go.doc #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working with this it was not immediately clear that the `version` parameter was not simply a string. I figured it out reading the code, and hopefully this little update will be useful to others too.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Open
tbpg
requested changes
Apr 1, 2022
.gitignore
Outdated
| @@ -1 +1,4 @@ | |||
| *.jar | |||
|
|
|||
| # editor files | |||
| *.idea | |||
tika/doc.go
Outdated
Comment on lines
26
to
29
| for removing the file when no longer needed. Version is a custom type, | ||
| and should be passed as such. There are constants in the code for these. | ||
| The following example downloads version 1.21 to the named JAR in the | ||
| current working directory. |
There was a problem hiding this comment.
Suggested change
| for removing the file when no longer needed. Version is a custom type, | |
| and should be passed as such. There are constants in the code for these. | |
| The following example downloads version 1.21 to the named JAR in the | |
| current working directory. | |
| for removing the file when no longer needed. | |
| Version is a custom type, | |
| and should be passed as such. There are constants in the code for these. | |
| The following example downloads version 1.21 to the named JAR in the | |
| current working directory. |
(New paragraph, need to adjust line breaks.)
1. new lines in doc.go 2. new line at the endo of .gitignore
|
Hi @tbpg, thanks for the feedback. I've made those requested changes now. Hope it looks alright |
tbpg
approved these changes
Apr 1, 2022
|
the lint failure is unclear to me, is there something I need to change? |
|
@nathj07, would you mind pulling in the latest changes from main? Looks like I don't have edit access. I updated the CI config and it seems to be working now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with this it was not immediately clear that the
versionparameter was not simply a string.I figured it out reading the code, and hopefully this little update will be useful to others too.