Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an error if the JAR file doesn't exist #28

Open
andymanning opened this issue May 5, 2021 · 1 comment
Open

Return an error if the JAR file doesn't exist #28

andymanning opened this issue May 5, 2021 · 1 comment
Assignees

Comments

@andymanning
Copy link
Contributor

andymanning commented May 5, 2021

As a developer creating a tika service using a pre-downloaded JAR file
I want to know if the jar file cannot be found
So that I can report an error

eg.
server, err := tika.NewServer("./lib/tika-server.jar", "1080")

if tika-server.jar is not found in ./lib then an error should be returned.

The error handling in the Start function doesn't return the error when running in background context

func (s *Server) Start(ctx context.Context) error { if _, err := os.Stat(s.jar); os.IsNotExist(err) { return err }

Please assign this issue to me, I'll fix.

@tbpg
Copy link
Member

tbpg commented May 6, 2021

Go for it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants