Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AK certificate chain retrieval #164

Merged
merged 14 commits into from
Mar 3, 2022
Merged

Add AK certificate chain retrieval #164

merged 14 commits into from
Mar 3, 2022

Conversation

jessieqliu
Copy link
Contributor

Adds an optional intermediate_certs field to Attestation to store the certificate chain for the AK cert. If the validateCertChain flag in AttestOpts is specified, Key.Attest will retrieve the certificate chain for the AK cert.

Also updates documentation with instructions to resolve a program is not executable error for protoc-gen-go, based on this thread

josephlr
josephlr reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkl73 can you finish up the review here? I'll be out of town this week.

client/attest.go Show resolved Hide resolved
client/attest.go Outdated Show resolved Hide resolved
client/attest.go Outdated Show resolved Hide resolved
client/attest.go Outdated Show resolved Hide resolved
client/attest.go Outdated Show resolved Hide resolved
client/attest_test.go Show resolved Hide resolved
@josephlr josephlr requested a review from jkl73 February 22, 2022 07:56
jkl73
jkl73 reviewed Feb 23, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
client/attest.go Outdated Show resolved Hide resolved
jkl73
jkl73 reviewed Feb 26, 2022
View reviewed changes
client/attest.go Outdated Show resolved Hide resolved
client/attest.go Outdated Show resolved Hide resolved
client/attest.go Outdated Show resolved Hide resolved
client/attest.go Outdated Show resolved Hide resolved
client/attest.go Outdated Show resolved Hide resolved
jkl73
jkl73 approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@jkl73 jkl73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client/attest_test.go Outdated Show resolved Hide resolved
client/attest.go Show resolved Hide resolved
@jessieqliu jessieqliu merged commit 66ec981 into master Mar 3, 2022
@josephlr josephlr deleted the ak_cert branch March 8, 2022 09:31
@josephlr josephlr mentioned this pull request Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkl73 jkl73 jkl73 approved these changes

@josephlr josephlr Awaiting requested review from josephlr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jessieqliu @josephlr @jkl73