[launcher] Add configurable /dev/shm size and tmpfs mount option #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
alexmwu
force-pushed
the
tmpfs
branch
2 times, most recently
from
15af756
to
d11dd9c
Compare
|
/gcbrun |
alexmwu
force-pushed
the
tmpfs
branch
2 times, most recently
from
18e7333
to
f60e1c8
Compare
|
/gcbrun |
alexmwu
force-pushed
the
tmpfs
branch
2 times, most recently
from
1d38d36
to
9609cf4
Compare
CS operators can use tee-dev-shm-size to increase the size of the /dev/shm mount for the workload.
alexmwu
changed the title
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
alexmwu
force-pushed
the
tmpfs
branch
2 times, most recently
from
29195f6
to
6244399
Compare
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
jkl73
reviewed
Jul 3, 2024
launcher/spec/launch_policy.go
Outdated
Comment on lines
108
to
114
| // default is debug only for memoryMonitoring | ||
| if v, ok := imageLabels[memoryMonitoring]; ok { | ||
| launchPolicy.AllowedMemoryMonitoring, err = toPolicy(memoryMonitoring, v) | ||
| if err != nil { | ||
| return LaunchPolicy{}, fmt.Errorf("invalid image LABEL '%s'; contact the image author", memoryMonitoring) | ||
| } | ||
| } |
Add tmpfs mount support, with destination and size options.
Add launchermount package and LaunchPolicy for AllowedMountDestinations.
launchermount has a new Mount interface and a TmpfsMount type.
LaunchPolicy now supports tee.launch_policy.allow_mount_destination,
which specifies allowed parent filepaths to mount on via a PATH-like string.
This tests the allowed mount points for tmpfs mounts and /dev/shm size.
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CS operators can use tee-dev-shm-size to increase the size of the /dev/shm mount for the workload.
CS operators can use
tee-mountto specify tmpfs mounts in the running container. For example:type=tmpfs,source=tmpfs,destination=/tmp;type=tmpfs,source=tmpfs,destination=/tmp2,size=12345.This interacts with the
tee.launch_policy.allow_mount_destinationlaunch policy that configures what the allowable mount points for a given workload are.