[launcher] Try to fix cloudbuild for launcher #458
Conversation
|
/gcbrun |
Still experiencing empty files in OEM partition, try more logging and careful mount in the script. Move cloudbuild.yaml from root to launcher directory Signed-off-by: Jiankun Lu <jiankun@google.com>
|
/gcbrun |
| dynamic_substitutions: true | ||
| pool: | ||
| name: 'projects/confidential-space-images-dev/locations/us-west1/workerPools/cs-image-build-vpc' |
There was a problem hiding this comment.
Remove this private pool requirement, so people can submit the image build in their own project
There was a problem hiding this comment.
Used to have this to build images in the private pool. But I realize it's fine to have the image building step without private pool, just put tests in the private pool.
Good thing is people can now use this cloudbuild file directly to build image in their own project for testing and debugging
| dynamic_substitutions: true | ||
| pool: | ||
| name: 'projects/confidential-space-images-dev/locations/us-west1/workerPools/cs-image-build-vpc' |
|
|
||
| # Now the oem partition is sealed, we mount it to print it's content | ||
| if [[ ! -d /mnt/disks/oem ]]; then | ||
| mkdir /mnt/disks/oem |
There was a problem hiding this comment.
I think it is fine as this is not get persistent, just a tmp build environment
| @@ -132,8 +132,12 @@ main() { | |||
| # Make sure cache is flushed for the OEM partition. | |||
| sync ${OEM_PATH} | |||
|
|
|||
| # Remount as read-only to avoid unexpected changes | |||
There was a problem hiding this comment.
Why do we need this? Are you worried that some other thing is modifying the OEM partition after the fact? Wouldn't that get reflected in the dm-verity?
There was a problem hiding this comment.
yes, the behavior I saw is files are all good before the preload.sh finish, but somehow got corrupted before the dm-verity sealing step. So dm-verity looks all good, but the files are still corrupted.
Remount it as read-only (as it should be before this script) just to make sure it doesn't get overwritten accidentally
Still experiencing empty files in OEM partition, try more logging and careful mount in the script.
Also moved
cloudbuild.yamlfrom the root directory to launcher/ directory