Import RSA signing keys with PCR policies #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BenDHillier We should rebase this on #73 and use the consolidated handling to use the existing Signer code with these imported keys. |
BenDHillier
force-pushed
the
import-rsa-pcr
branch
from
a55e40d
to
ad913b2
Compare
josephlr
reviewed
Feb 28, 2020
josephlr
reviewed
Feb 28, 2020
josephlr
reviewed
Feb 28, 2020
josephlr
reviewed
Feb 28, 2020
josephlr
reviewed
Feb 28, 2020
josephlr
reviewed
Feb 28, 2020
josephlr
reviewed
Feb 28, 2020
josephlr
reviewed
Feb 28, 2020
josephlr
approved these changes
Feb 28, 2020
josephlr
force-pushed
the
import-rsa-pcr
branch
from
bbd98bb
to
2bd4bd8
Compare
These should be in key_conversion.go Signed-off-by: Joe Richey <joerichey@google.com>
ImportSigningKey() returns a *Key to the user. GetSigner() can then be used to get a crypto.Signer to sign digests. Authored-by: Ben Hillier <bhillier@google.com> Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
josephlr
force-pushed
the
import-rsa-pcr
branch
from
2bd4bd8
to
20357fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add importing for RSA signing keys.
The import flow returns a *Key to the user, which can be used to get a tpmSigner to sign digests.