Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail on curent master #240

Closed
josephlr opened this issue Apr 8, 2021 · 0 comments · Fixed by #241
Closed

Tests fail on curent master #240

josephlr opened this issue Apr 8, 2021 · 0 comments · Fixed by #241
Assignees
@josephlr

Comments

@josephlr
Copy link
Member

josephlr commented Apr 8, 2021 •
edited

Right now, running go test -p 1 ./... results in the following failure (on go 1.16.2):

--- FAIL: TestEncodingPackTypeInvalid (0.00s)
    encoding_test.go:54: The packing function incorrectly succeeds for a non-packable value

This looks to be caused by ioutil.Discard being a valid value for packing. As of Go 1.16, this value was changed to be io.Discard which is just an empty struct (which is a valid value for packing).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephlr josephlr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Invalid Pack test for ioutil.Discard google/go-tpm
1 participant
@josephlr