-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING CHANGE] BaseClientService isn't thread-safe #617
Conversation
Solve googleapis#592. Change the API of ConfigurableMessageHandler to expose an enumerable of handlers and interceptors and NOT a list.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1. It contains by mistake another pull request (googleapis#617) 2. Delete all WP Silverlight projects 3. Change PCL profile to 92 4. Add appveyor
Ping... I'll be happy to get some feedback on this one. |
{ | ||
get | ||
{ | ||
lock (unsuccessfulResponseHandlersLock) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Can you setup you account to be recognized by google bot? (currently it says cla:no). This is probably done by signing CLA for your personal e-mail (if associated with your github account) or properly linking your github account with you corp e-mail. |
I signed it and changed my primary account email to google as well. |
CLAs look good, thanks! |
I just improved the comment. I kept the 3 locks (since I think it's a better approach, lock only what you need with minimized scope). Ready for a (maybe?) final review. |
/// <summary>Gets a list of <see cref="IHttpUnsuccessfulResponseHandler"/>.</summary> | ||
public IList<IHttpUnsuccessfulResponseHandler> UnsuccessfulResponseHandlers | ||
/// <summary> | ||
/// Gets a snapshot of <see cref="IHttpUnsuccessfulResponseHandler"/>s associated with this instance's handlers. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Besides the nit, LGTM. |
BaseClientService isn't thread-safe
In googleapis#617, I presented a new breaking change to the library. With this change we are going to avoid that, by adding back the list getter, which is OBSOLETE now.
Solve #592. Change the API of ConfigurableMessageHandler to expose an
enumerable of handlers and interceptors and NOT a list.