Issue #238 - Signed Google.Apis #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a signing rule that uses the key from c:\code\google.apis.snk
- Change the release process and the publisher to sign dlls - Add a git repository which is used by the release process.
|
Generally LGTM, I'd like to learn more about how we manage the .snk key (let's chat offline). |
| @@ -55,8 +55,8 @@ | |||
| <Compile Include="Program.cs" /> | |||
| <Compile Include="ProjectExtenstions.cs" /> | |||
| <Compile Include="Properties\AssemblyInfo.cs" /> | |||
| <Compile Include="Repositories\Git.cs" /> | |||
| <Compile Include="Repositories\Hg.cs" /> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Should we remove the .hgignore file? I don't think we need it anymore do we. |
Last commit was missing some right dependencies (usage of Zlib.Portable instead Zlib.Portable.Signed NuGet package, dll name, by the way, remained Zlib.Portable)
peleyal
added a commit
that referenced
this pull request
Jul 7, 2015
Issue #238 - Signed Google.Apis
aiuto
added a commit
to google/apis-client-generator
that referenced
this pull request
Nov 19, 2015
1. Fixed the string transformation where if a reserved keyword is used with invalid characters, we were not stripping out the invalid character when appending the reserved keyword with "__". This was causing something like '$object' to be transformed into '$object__' instead of 'object__' 2. Support Strong Named Assemblies in C# .NET Issue 238 (googleapis/google-api-dotnet-client#238) - Support Strong Named Assemblies Based on committing googleapis/google-api-dotnet-client#550 (was pushed on July 7th 2015) 3. Release 1.9.2 of the .NET client library for Google Apis. - Clone tempalte directory for 1.9.2 - Add 1.9.2 as test to targets.json - Clone golden tests for 1.9.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change contains the following:
UPDATE: Zlib.Portable already posted a new signed (not beta) version of their library. 馃憤
I followed Linda instructions;
The key was created using the following:
sn.exe -k asecret.snk
Getting the public key from the secret:
sn.exe -p asecret.snk publicKey.snk
Then I added the public key to the repo.
Follows up, to do after committing this one.
Follow Jon's comment:
"The most likely reason for singing a test assembly is so that you can trust it with InternalsVisibleTo in the production code. I've lost where we've got to with friend assemblies, but it can certainly be very helpful. It means you may need conditional compilation, however - see https://github.com/nodatime/nodatime/blob/master/src/NodaTime/Properties/AssemblyInfo.cs"
Sanitize the project configurations聽#558