Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also accept InputStream at setServiceAccountPrivateKeyFromP12File #1011

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Also accept InputStream at setServiceAccountPrivateKeyFromP12File #1011

merged 1 commit into from
Sep 13, 2018

Conversation

kliakos
Copy link
Contributor

@kliakos kliakos commented May 17, 2016

In order to overcome problems when running from inside jar.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@kliakos
Copy link
Contributor Author

kliakos commented May 17, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Collaborator

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the super late review of this. We are getting back up to speed on these reviews.

This PR looks good except it's against the master branch which is not the primary branch of this repo (#1152). Please update this PR to target the dev branch.

@kliakos kliakos changed the base branch from master to dev September 13, 2018 03:59
@kliakos
Copy link
Contributor Author

kliakos commented Sep 13, 2018

Ok, changed target branch to dev

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2018
@chingor13 chingor13 merged commit 0487d59 into googleapis:dev Sep 13, 2018
@chingor13 chingor13 removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2018
@chingor13 chingor13 mentioned this pull request Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants