-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GTLRService responsePartWithMIMEPart:] sets error for "204 No Content" responses #346
Comments
Can you provide some more details? Normally there are also headers on the mime part which would include a Content-ID, etc. It helps to know we're looking at the same setup. Edit: Exactly where else there are CRLFs vs. just CR or LF could also come into play here. |
If my guess is correct, a little more about what is happening in this batch might help. I'm guessing you are making multiple request, and one part is succeeding, but with no new content (because of the ETag)? So this this likely isn't just about this parse being correct, but also ensuring everything else "works" in the case for the batch. |
If a batch include a delete, this it might not have any data in the reply, that was forcing an error, instead allow it succeed with non JSON, this should be like the flows for single objects. Fixes google#346
If one of the methods was a delete, it might not have any data in the reply, that was forcing an error, instead allow it succeed with no JSON coming back, this should be like the flows for single objects. Fixes google#346
If one of the methods was a delete, it might not have any data in the reply, that was forcing an error, instead allow it succeed with no JSON coming back, this should be like the flows for single objects. Fixes google#346
If one of the methods was a delete, it might not have any data in the reply, that was forcing an error, instead allow it succeed with no JSON coming back, this should be like the flows for single objects. Fixes google#346
If one of the methods was a delete, it might not have any data in the reply, that was forcing an error, instead allow it succeed with no JSON coming back, this should be like the flows for single objects. Fixes #346
Repro steps:
body
property is set to:HTTP/1.1 204 No Content
ETag: ""
Date:
<CRLFCRLF (must end in "\r\n\r\n" with no additional data)>
Expected:
The returned GTLRBatchResponsePart instance should not have its
parseError
orJSON
properties set, since no error occurred and no content was returned.Actual:
parseError
is set.Domain: "com.google.GTLRServiceDomain" (kGTLRServiceErrorDomain).
Code: -3001 (GTLRServiceErrorBatchResponseUnexpected).
The text was updated successfully, but these errors were encountered: