Switches DYLIB_INSTALL_NAME_BASE to @rpath to fix "dyld: Library not … #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loaded: @loader_path/Frameworks" when GTLR is embedded in main application and linked in separate framework as referenced in issue 69.
|
fyi - We picked up an updated AppAuth/GTMAppAuth dependency in another CL and we're trying to get travis happy with that (another active PR) before doing yet more build releated changes. |
|
Told travis to respin, not sure if that will move up to more recent files on not, but hopefully it will and we'll get a better state of things. |
|
Cool, thanks for the update. Let me know if I need to do anything else on my end to have it re-trigger whenever appropriate. |
|
Looks like it reruns things still based on the state of your branch. Can you merge/rebase to the the current state of |
|
Should be all set. Sorry, I should have commented when I merged to catch it up. |
|
And it looks like travis was happy with it, so thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…loaded: @loader_path/Frameworks" when GTLR is embedded in main application and linked in separate framework as referenced in issue #69 (adjusted on GTLRiOS and GTLROSX)