Allow media file uploads to be gzipped #91
Comments
|
Uploads were playing very badly with compress.zlib - we were seeing poor batching on the upload (resulting in more network traffic in the end, and slower uploads). That could be isolated though - could you try removing the hardcoded disableGzip and see whether you get performance benefits? |
|
I removed it temporarily and saw marginal performance improvements (5 jobs per 10 seconds instead of 3-4 per 10 seconds, which could be coincidence). No concrete benchmarks though. I'll do some more testing tonight and see if I can get some actual numbers. |
ianbarber
pushed a commit
to ianbarber/google-api-php-client
that referenced
this issue
Mar 2, 2014
Make config GZIP possible to enable separately to the main gzip. It still defaults to false, but at least in situations like googleapis#91 where it is showing benefit it can be easily enabled. In order to maintain the defaults though, the config names have become slightly confusing (one disable, one enable). I've added some constants to try and work around that, but I may be just setting us up for future problems!
Merged
yoshi-automation
added
🚨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now uploads are explicitly uncompressed which is currently costing us extra money in bandwidth uploading to Google as well as storage within Google Cloud Storage. Having the option to gzip uploads to Cloud Storage would be very useful and potentially save people some money.
Would this be as simple as removing the hardcoded
$httpRequest->disableGzip()line and making it flagged? That should run it through thecompress.zlib://handler and just simply work.The text was updated successfully, but these errors were encountered: