Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from "uritemplate" to "uritemplate.py" #57

Closed
sloria opened this issue Feb 24, 2015 · 6 comments
Closed

Switch from "uritemplate" to "uritemplate.py" #57

sloria opened this issue Feb 24, 2015 · 6 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@sloria
Copy link

sloria commented Feb 24, 2015

There are at least 2 URI template packages on the PyPI: uritemplate and uritemplate.py. Both of these packages use uritemplate as the package name to be imported, which causes a conflict when both are installed (see python-hyper/uritemplate#14).

I propose that this project depend on uritemplate.py because:

  • uritemplate.py is API-compatible with uritemplate, but the reverse is not true. I have confirmed that this library works with uritemplate.py.
  • Other projects depend on uritemplate.py. For example, we are currently working on a project that depends on both github3.py (GitHub API client) and google-api-python-client. Installing both results in an immediate ImportError due to the uritemplate conflict.

This is a simple, low-risk change that would aid compatibility with other projects.

Thoughts?

@pedgar
Copy link

pedgar commented Mar 12, 2015

+1 We are having the same issue of incompatibility between the 'github3.py' and 'google-api-python-client' libraries.

Switching this project over to using uritemplate.py would make life much easier.

@nathanielmanistaatgoogle
Copy link
Contributor

Even though the technical aspect of the change sounds very simple I'd like to know more before welcoming a pull request welcoming the change. This smells like a political problem, like an unclean fork. What's being done upstream between uritemplate and uritemplate.py to resolve the problem?

@rodneykeeling
Copy link

Any update on this issue? Discogs is trying to use this client for the YouTube v3 API but we are running into this same error.

@gcarothers
Copy link

This hasn't gone away. As to the upstream, it seems that uritemplate.py claims API compatibility with uritemplate which hasn't had an update since Aug 27, 2013. While it may be a political issue the effect is very real, running an ansible playbook that needs to talk to google cloud and github at the same time is... challenging

@nathanielmanistaatgoogle
Copy link
Contributor

For folks subscribed to this issue but not otherwise watching the project: #146 just went by and I didn't realize during its review that this issue was opened on the matter. Has this issue budged at all in the last few months? I see recent commits over at https://github.com/uri-templates/uritemplate-py/commits/master including one by @graingert.

@nathanielmanistaatgoogle
Copy link
Contributor

For everyone affected by this issue: has anyone ever bothered to contact the maintainers of both libraries and simply ask what's up? It's been nearly three years since either of them cut a release; I wonder if they can be merged and the whole problem solved properly.

simon-weber added a commit to venmo/google-api-python-client that referenced this issue Oct 13, 2016
As of uritemplate 3.0.0 and uritemplate.py 3.0.2, the two packages are equivalent.
There were no changes to functionality; see
https://github.com/sigmavirus24/uritemplate/blob/master/HISTORY.rst.
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

7 participants