Skip to content

Commit

Permalink
Fixed incompatibilities with Ruby 1.8.6
Browse files Browse the repository at this point in the history
git-svn-id: https://google-api-ruby-client.googlecode.com/svn/trunk@71 c1d61fac-ed7f-fcc1-18f7-ff78120a04ef
  • Loading branch information
Bob Aman committed Oct 13, 2010
1 parent 61fc497 commit 5572a73
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 13 deletions.
20 changes: 12 additions & 8 deletions lib/google/api_client/discovery.rb
Expand Up @@ -442,15 +442,19 @@ def generate_request(parameters={}, body='', headers=[])
#
# @return [Hash] The parameter descriptions.
def parameter_descriptions
@parameter_descriptions ||= Hash[self.description['parameters'] || {}]
@parameter_descriptions ||= (
self.description['parameters'] || {}
).inject({}) { |h,(k,v)| h[k]=v; h }
end

##
# Returns an <code>Array</code> of the parameters for this method.
#
# @return [Array] The parameters.
def parameters
@parameters ||= Hash[self.description['parameters'] || {}].keys
@parameters ||= ((
self.description['parameters'] || {}
).inject({}) { |h,(k,v)| h[k]=v; h }).keys
end

##
Expand All @@ -463,9 +467,9 @@ def parameters
# # A list of all required parameters.
# method.required_parameters
def required_parameters
@required_parameters ||= Hash[self.parameter_descriptions.select do |k, v|
@required_parameters ||= ((self.parameter_descriptions.select do |k, v|
v['required']
end].keys
end).inject({}) { |h,(k,v)| h[k]=v; h }).keys
end

##
Expand All @@ -478,9 +482,9 @@ def required_parameters
# # A list of all optional parameters.
# method.optional_parameters
def optional_parameters
@optional_parameters ||= Hash[self.parameter_descriptions.reject do |k, v|
@optional_parameters ||= ((self.parameter_descriptions.reject do |k, v|
v['required']
end].keys
end).inject({}) { |h,(k,v)| h[k]=v; h }).keys
end

##
Expand All @@ -493,9 +497,9 @@ def optional_parameters
# @return [NilClass] <code>nil</code> if validation passes.
def validate_parameters(parameters={})
parameters = self.normalize_parameters(parameters)
required_variables = Hash[self.parameter_descriptions.select do |k, v|
required_variables = ((self.parameter_descriptions.select do |k, v|
v['required']
end].keys
end).inject({}) { |h,(k,v)| h[k]=v; h }).keys
missing_variables = required_variables - parameters.keys
if missing_variables.size > 0
raise ArgumentError,
Expand Down
4 changes: 2 additions & 2 deletions spec/google/api_client/discovery_spec.rb
Expand Up @@ -173,7 +173,7 @@
method.should == 'POST'
uri.should ==
'https://www.googleapis.com/prediction/v1/training?query=12345'
Hash[headers].should == {}
(headers.inject({}) { |h,(k,v)| h[k]=v; h }).should == {}
body.should respond_to(:each)
end

Expand Down Expand Up @@ -207,7 +207,7 @@
{'query' => '12345'}
)
method, uri, headers, body = request
headers = Hash[headers]
headers = headers.inject({}) { |h,(k,v)| h[k]=v; h }
headers.keys.should include('Authorization')
headers['Authorization'].should =~ /^OAuth/
end
Expand Down
4 changes: 2 additions & 2 deletions tasks/gem.rake
Expand Up @@ -19,14 +19,14 @@ namespace :gem do
s.extra_rdoc_files = %w( README )
s.rdoc_options.concat ['--main', 'README']

s.add_runtime_dependency('signet', '>= 0.1.1')
s.add_runtime_dependency('signet', '>= 0.1.3')
s.add_runtime_dependency('addressable', '>= 2.2.2')
s.add_runtime_dependency('httpadapter', '>= 0.2.0')
s.add_runtime_dependency('json', '>= 1.1.9')
s.add_runtime_dependency('extlib', '>= 0.9.15')

s.add_development_dependency('rake', '>= 0.7.3')
s.add_development_dependency('rspec', '~> 1.3.0')
s.add_development_dependency('rspec', '~> 1.2.9')
s.add_development_dependency('launchy', '>= 0.3.2')
s.add_development_dependency('diff-lcs', '>= 1.1.2')

Expand Down
4 changes: 3 additions & 1 deletion tasks/spec.rake
Expand Up @@ -7,7 +7,9 @@ namespace :spec do
if RCOV_ENABLED
if `which rcov`.strip == ""
STDERR.puts "Please install rcov:"
STDERR.puts "sudo gem install relevance-rcov"
STDERR.puts(
"sudo gem install relevance-rcov --source http://gems.github.com/"
)
exit(1)
end
t.rcov = true
Expand Down

0 comments on commit 5572a73

Please sign in to comment.