Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve .npmignore #127

Merged
merged 1 commit into from
Mar 1, 2017
Merged

Improve .npmignore #127

merged 1 commit into from
Mar 1, 2017

Conversation

denar90
Copy link
Contributor

@denar90 denar90 commented Mar 1, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2017
@coveralls
Copy link

coveralls commented Mar 1, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 94.233% when pulling c443035 on denar90:patch-1 into 55866cb on google:master.

jmdobry
jmdobry approved these changes Mar 1, 2017
View reviewed changes
Copy link
Contributor

@jmdobry jmdobry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though in the long run I'd prefer we switch away from using .npmignore and start using the "files" section of package.json.

@jmdobry jmdobry merged commit 6529522 into googleapis:master Mar 1, 2017
@denar90 denar90 deleted the patch-1 branch March 1, 2017 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdobry jmdobry jmdobry approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denar90 @coveralls @jmdobry @googlebot