Skip to content
This repository has been archived by the owner on Apr 6, 2021. It is now read-only.

PIN list behaves oddly on devices with ListView bounce #45

Closed
ThomasHabets opened this issue Oct 10, 2014 · 4 comments
Closed

PIN list behaves oddly on devices with ListView bounce #45

ThomasHabets opened this issue Oct 10, 2014 · 4 comments

Comments

@ThomasHabets
Copy link
Contributor

Original issue 45 created by falargle on 2011-02-28T23:36:47.000Z:

What steps will reproduce the problem?

  1. touch and drag PIN up and down on a device that comes with a "bouncing" version of ListView (ie: Samsung Epic 4G)

What is the expected output? What do you see instead?
PIN numbers should move up and down, unobscured. Instead, due to the way the ListView is sized, the bottom PIN will get cut off as it scrolls past the bottom of the ListView

What version of the product are you using? On what operating system?
0.54, under Android 2.2.1.

Please provide any additional information below.
I've attached a patch against 2b7e90a4d3ceb770aec1c8e12600ce85c3389a59 that changes the layout to expand the PIN ListView to the full amount of available space, regardless of content size. This has the side-effect of showing a divider at the bottom of the last item in the list, but this is pretty standard for Android ListViews.

@ThomasHabets
Copy link
Contributor Author

Not applicable to this product. Please reopen in https://github.com/google/google-authenticator-android if applicable.

@ThomasHabets
Copy link
Contributor Author

Comment #1 originally posted by markus@google.com on 2011-03-09T21:38:15.000Z:

<empty>

@ThomasHabets
Copy link
Contributor Author

Comment #2 originally posted by danieltay.digi on 2011-04-25T18:51:00.000Z:

NOT ALLOWED AT ALL

@ThomasHabets
Copy link
Contributor Author

Comment #3 originally posted by CherylRenwick19 on 2014-03-01T19:43:28.000Z:

Obviously I am not the only one that has problems with there e mail account, as this phone was purchase new so wal mart sold it as new therefore I was thinking I was starting new with every thing ? I have been trying to retrieve my email account name is Cheryl Renwick owner of chinamom53@gmail.com it is very important that I retrive this email address so if you would please return this email address back to me. How would you like it if your email got hacked into and some else had control of it ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant