Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

Save As dialog creates empty files, asks to overwrite #12

Closed
jpgaribotti opened this issue Jul 1, 2015 · 2 comments
Closed

Save As dialog creates empty files, asks to overwrite #12

jpgaribotti opened this issue Jul 1, 2015 · 2 comments
Assignees
@jpgaribotti
Labels
bug
Milestone
v1.8.56.0

Comments

@jpgaribotti
Copy link
Contributor

Repro steps:

  • Create new file from within an application.
  • Select Save as from windows menu and then select Drive.
  • When saving, an empty file is created of the same name as the "Save As" filename. In Citrix environments, this is repeated for each and every folder you navigate to.
  • You are then warned that a file already exists and are asked to overwrite the destination.
@jpgaribotti jpgaribotti self-assigned this Jul 1, 2015
@jpgaribotti jpgaribotti added the bug label Jul 1, 2015
@pshorney
Copy link

pshorney commented Jul 2, 2015

Confirmed see same results i.e. multiple files in Word and Powerpoint

jpgaribotti pushed a commit to jpgaribotti/google-drive-shell-extension that referenced this issue Jul 3, 2015
Save As dialog no longer asks to overwrite new files - google#12
dfcf989 
Added three macros to check constraints and homogenize error signaling.

Removed a block that was adding newly created files to the ignoredIds map and preventing the explorer view from showing the new file.

Corrected an error return in _GetDataFromID from invalid argument to file not found.

Simplified the code for GetAttributesOf.
@jpgaribotti jpgaribotti mentioned this issue Jul 3, 2015
Merged
@jpgaribotti jpgaribotti added this to the v1.8.55.0 milestone Jul 6, 2015
@jpgaribotti
Copy link
Contributor Author

Small regression introduced with the pull request: Overwriting existing files fails with "The system cannot find the path specified."

As we no longer create dummy files when checking if a path exists, "existing" files that haven't been downloaded don't actually yet exist, and so can't be overwritten.

@jpgaribotti jpgaribotti reopened this Jul 6, 2015
@jpgaribotti jpgaribotti modified the milestones: v1.8.56.0, v1.8.55.0 Jul 24, 2015
This was referenced Aug 10, 2015
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jpgaribotti jpgaribotti

Labels
bug
Projects
None yet
Milestone
v1.8.56.0
Development

No branches or pull requests
2 participants
@jpgaribotti @pshorney