Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on annotated fully-qualified class names #60

Closed
mernst opened this issue Jul 16, 2016 · 2 comments
Closed

Crash on annotated fully-qualified class names #60

mernst opened this issue Jul 16, 2016 · 2 comments

Comments

@mernst
Copy link
Contributor

mernst commented Jul 16, 2016

The tool crashes on annotated fully-qualified class names.
Consider this test case:

import org.checkerframework.checker.nullness.qual.*;

public class FullyQualified {

    public void format1(java.lang.String a1, java.lang. @Nullable Object... a2) {
        // body
    }

}
cushon added a commit to cushon/google-java-format that referenced this issue Jul 16, 2016
@cushon
Handle type annotations on fully-qualified names
f949a66 
Fixes google#60
cushon added a commit to cushon/google-java-format that referenced this issue Jul 16, 2016
@cushon
Handle type annotations on fully-qualified names
9631a50 
Context: google#60
@cushon cushon mentioned this issue Jul 16, 2016
Merged
cushon added a commit that referenced this issue Jul 16, 2016
@cushon
Handle type annotations on fully-qualified names (#64)
1b28017 
Context: #60
@cushon
Copy link
Collaborator

cushon commented Jul 16, 2016

#64 should fix the crash, but some of the formatting decisions around type annotations may not be final yet. Is there a convention for spaces between type annotations in qualified names and the .?

@mernst
Copy link
Contributor Author

mernst commented Jul 16, 2016

JLS section 9.7.4 writes java.lang.@TA Object without the space.

@cushon cushon closed this as completed Jul 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mernst @cushon