Skip to content

Commit

Permalink
Remove the legacy internal GTEST_DISALLOW_* macros
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 443715444
Change-Id: I3ffd54b63d2728ae4a668ee7875c8c3c8188087c
  • Loading branch information
derekmauro authored and Copybara-Service committed Apr 22, 2022
1 parent b85864c commit bf66935
Show file tree
Hide file tree
Showing 32 changed files with 290 additions and 159 deletions.
12 changes: 8 additions & 4 deletions googlemock/include/gmock/gmock-actions.h
Expand Up @@ -393,7 +393,8 @@ class DefaultValue {

private:
const T value_;
GTEST_DISALLOW_COPY_AND_ASSIGN_(FixedValueProducer);
FixedValueProducer(const FixedValueProducer&) = delete;
FixedValueProducer& operator=(const FixedValueProducer&) = delete;
};

class FactoryValueProducer : public ValueProducer {
Expand All @@ -404,7 +405,8 @@ class DefaultValue {

private:
const FactoryFunction factory_;
GTEST_DISALLOW_COPY_AND_ASSIGN_(FactoryValueProducer);
FactoryValueProducer(const FactoryValueProducer&) = delete;
FactoryValueProducer& operator=(const FactoryValueProducer&) = delete;
};

static ValueProducer* producer_;
Expand Down Expand Up @@ -478,7 +480,8 @@ class ActionInterface {
virtual Result Perform(const ArgumentTuple& args) = 0;

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(ActionInterface);
ActionInterface(const ActionInterface&) = delete;
ActionInterface& operator=(const ActionInterface&) = delete;
};

// An Action<F> is a copyable and IMMUTABLE (except by assignment)
Expand Down Expand Up @@ -951,7 +954,8 @@ class ReturnAction {
R value_before_cast_;
Result value_;

GTEST_DISALLOW_COPY_AND_ASSIGN_(Impl);
Impl(const Impl&) = delete;
Impl& operator=(const Impl&) = delete;
};

// Partially specialize for ByMoveWrapper. This version of ReturnAction will
Expand Down
7 changes: 5 additions & 2 deletions googlemock/include/gmock/gmock-matchers.h
Expand Up @@ -313,7 +313,9 @@ class StringMatchResultListener : public MatchResultListener {
private:
::std::stringstream ss_;

GTEST_DISALLOW_COPY_AND_ASSIGN_(StringMatchResultListener);
StringMatchResultListener(const StringMatchResultListener&) = delete;
StringMatchResultListener& operator=(const StringMatchResultListener&) =
delete;
};

// Anything inside the 'internal' namespace IS INTERNAL IMPLEMENTATION
Expand Down Expand Up @@ -2555,7 +2557,8 @@ class WhenSortedByMatcher {
const Comparator comparator_;
const Matcher<const ::std::vector<LhsValue>&> matcher_;

GTEST_DISALLOW_COPY_AND_ASSIGN_(Impl);
Impl(const Impl&) = delete;
Impl& operator=(const Impl&) = delete;
};

private:
Expand Down
9 changes: 6 additions & 3 deletions googlemock/include/gmock/gmock-nice-strict.h
Expand Up @@ -169,7 +169,8 @@ class GTEST_INTERNAL_EMPTY_BASE_CLASS NiceMock
}

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(NiceMock);
NiceMock(const NiceMock&) = delete;
NiceMock& operator=(const NiceMock&) = delete;
};

template <class MockClass>
Expand Down Expand Up @@ -210,7 +211,8 @@ class GTEST_INTERNAL_EMPTY_BASE_CLASS NaggyMock
}

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(NaggyMock);
NaggyMock(const NaggyMock&) = delete;
NaggyMock& operator=(const NaggyMock&) = delete;
};

template <class MockClass>
Expand Down Expand Up @@ -251,7 +253,8 @@ class GTEST_INTERNAL_EMPTY_BASE_CLASS StrictMock
}

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(StrictMock);
StrictMock(const StrictMock&) = delete;
StrictMock& operator=(const StrictMock&) = delete;
};

#undef GTEST_INTERNAL_EMPTY_BASE_CLASS
Expand Down
12 changes: 8 additions & 4 deletions googlemock/include/gmock/gmock-spec-builders.h
Expand Up @@ -677,7 +677,8 @@ class GTEST_API_ InSequence {
private:
bool sequence_created_;

GTEST_DISALLOW_COPY_AND_ASSIGN_(InSequence); // NOLINT
InSequence(const InSequence&) = delete;
InSequence& operator=(const InSequence&) = delete;
} GTEST_ATTRIBUTE_UNUSED_;

namespace internal {
Expand Down Expand Up @@ -1219,7 +1220,8 @@ class TypedExpectation : public ExpectationBase {
Matcher<const ArgumentTuple&> extra_matcher_;
Action<F> repeated_action_;

GTEST_DISALLOW_COPY_AND_ASSIGN_(TypedExpectation);
TypedExpectation(const TypedExpectation&) = delete;
TypedExpectation& operator=(const TypedExpectation&) = delete;
}; // class TypedExpectation

// A MockSpec object is used by ON_CALL() or EXPECT_CALL() for
Expand Down Expand Up @@ -1392,7 +1394,8 @@ class ActionResultHolder : public UntypedActionResultHolderBase {

Wrapper result_;

GTEST_DISALLOW_COPY_AND_ASSIGN_(ActionResultHolder);
ActionResultHolder(const ActionResultHolder&) = delete;
ActionResultHolder& operator=(const ActionResultHolder&) = delete;
};

// Specialization for T = void.
Expand Down Expand Up @@ -1425,7 +1428,8 @@ class ActionResultHolder<void> : public UntypedActionResultHolderBase {

private:
ActionResultHolder() {}
GTEST_DISALLOW_COPY_AND_ASSIGN_(ActionResultHolder);
ActionResultHolder(const ActionResultHolder&) = delete;
ActionResultHolder& operator=(const ActionResultHolder&) = delete;
};

template <typename F>
Expand Down
3 changes: 2 additions & 1 deletion googlemock/src/gmock-cardinalities.cc
Expand Up @@ -86,7 +86,8 @@ class BetweenCardinalityImpl : public CardinalityInterface {
const int min_;
const int max_;

GTEST_DISALLOW_COPY_AND_ASSIGN_(BetweenCardinalityImpl);
BetweenCardinalityImpl(const BetweenCardinalityImpl&) = delete;
BetweenCardinalityImpl& operator=(const BetweenCardinalityImpl&) = delete;
};

// Formats "n times" in a human-friendly way.
Expand Down
3 changes: 2 additions & 1 deletion googlemock/test/gmock-actions_test.cc
Expand Up @@ -869,7 +869,8 @@ class MockClass {
int(const std::unique_ptr<int>&, std::unique_ptr<int>));

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(MockClass);
MockClass(const MockClass&) = delete;
MockClass& operator=(const MockClass&) = delete;
};

// Tests that DoDefault() returns the built-in default value for the
Expand Down
3 changes: 2 additions & 1 deletion googlemock/test/gmock-cardinalities_test.cc
Expand Up @@ -54,7 +54,8 @@ class MockFoo {
MOCK_METHOD0(Bar, int()); // NOLINT

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(MockFoo);
MockFoo(const MockFoo&) = delete;
MockFoo& operator=(const MockFoo&) = delete;
};

// Tests that Cardinality objects can be default constructed.
Expand Down
38 changes: 27 additions & 11 deletions googlemock/test/gmock-function-mocker_test.cc
Expand Up @@ -202,7 +202,8 @@ class MockFoo : public FooInterface {
MOCK_METHOD(int, RefQualifiedOverloaded, (), (ref(&&), override));

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(MockFoo);
MockFoo(const MockFoo&) = delete;
MockFoo& operator=(const MockFoo&) = delete;
};

class LegacyMockFoo : public FooInterface {
Expand Down Expand Up @@ -274,7 +275,8 @@ class LegacyMockFoo : public FooInterface {
int RefQualifiedOverloaded() && override { return 0; }

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(LegacyMockFoo);
LegacyMockFoo(const LegacyMockFoo&) = delete;
LegacyMockFoo& operator=(const LegacyMockFoo&) = delete;
};

#ifdef _MSC_VER
Expand Down Expand Up @@ -492,7 +494,8 @@ class MockB {
MOCK_METHOD(void, DoB, ());

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(MockB);
MockB(const MockB&) = delete;
MockB& operator=(const MockB&) = delete;
};

class LegacyMockB {
Expand All @@ -502,7 +505,8 @@ class LegacyMockB {
MOCK_METHOD0(DoB, void());

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(LegacyMockB);
LegacyMockB(const LegacyMockB&) = delete;
LegacyMockB& operator=(const LegacyMockB&) = delete;
};

template <typename T>
Expand Down Expand Up @@ -557,7 +561,8 @@ class MockStack : public StackInterface<T> {
MOCK_METHOD((std::map<int, int>), ReturnTypeWithComma, (int), (const));

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(MockStack);
MockStack(const MockStack&) = delete;
MockStack& operator=(const MockStack&) = delete;
};

template <typename T>
Expand All @@ -575,7 +580,8 @@ class LegacyMockStack : public StackInterface<T> {
MOCK_CONST_METHOD1_T(ReturnTypeWithComma, std::map<int, int>(int)); // NOLINT

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(LegacyMockStack);
LegacyMockStack(const LegacyMockStack&) = delete;
LegacyMockStack& operator=(const LegacyMockStack&) = delete;
};

template <typename T>
Expand Down Expand Up @@ -645,7 +651,8 @@ class MockStackWithCallType : public StackInterfaceWithCallType<T> {
(Calltype(STDMETHODCALLTYPE), override, const));

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(MockStackWithCallType);
MockStackWithCallType(const MockStackWithCallType&) = delete;
MockStackWithCallType& operator=(const MockStackWithCallType&) = delete;
};

template <typename T>
Expand All @@ -659,7 +666,9 @@ class LegacyMockStackWithCallType : public StackInterfaceWithCallType<T> {
MOCK_CONST_METHOD0_T_WITH_CALLTYPE(STDMETHODCALLTYPE, GetTop, const T&());

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(LegacyMockStackWithCallType);
LegacyMockStackWithCallType(const LegacyMockStackWithCallType&) = delete;
LegacyMockStackWithCallType& operator=(const LegacyMockStackWithCallType&) =
delete;
};

template <typename T>
Expand Down Expand Up @@ -709,7 +718,9 @@ class MockOverloadedOnArgNumber {
MY_MOCK_METHODS1_;

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(MockOverloadedOnArgNumber);
MockOverloadedOnArgNumber(const MockOverloadedOnArgNumber&) = delete;
MockOverloadedOnArgNumber& operator=(const MockOverloadedOnArgNumber&) =
delete;
};

class LegacyMockOverloadedOnArgNumber {
Expand All @@ -719,7 +730,10 @@ class LegacyMockOverloadedOnArgNumber {
LEGACY_MY_MOCK_METHODS1_;

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(LegacyMockOverloadedOnArgNumber);
LegacyMockOverloadedOnArgNumber(const LegacyMockOverloadedOnArgNumber&) =
delete;
LegacyMockOverloadedOnArgNumber& operator=(
const LegacyMockOverloadedOnArgNumber&) = delete;
};

template <typename T>
Expand Down Expand Up @@ -751,7 +765,9 @@ class MockOverloadedOnConstness {
MY_MOCK_METHODS2_;

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(MockOverloadedOnConstness);
MockOverloadedOnConstness(const MockOverloadedOnConstness&) = delete;
MockOverloadedOnConstness& operator=(const MockOverloadedOnConstness&) =
delete;
};

TEST(MockMethodOverloadedMockMethodTest, CanOverloadOnConstnessInMacroBody) {
Expand Down
6 changes: 4 additions & 2 deletions googlemock/test/gmock-matchers-arithmetic_test.cc
Expand Up @@ -955,7 +955,8 @@ class AllArgsHelper {
MOCK_METHOD2(Helper, int(char x, int y));

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(AllArgsHelper);
AllArgsHelper(const AllArgsHelper&) = delete;
AllArgsHelper& operator=(const AllArgsHelper&) = delete;
};

TEST(AllArgsTest, WorksInWithClause) {
Expand All @@ -982,7 +983,8 @@ class OptionalMatchersHelper {
MOCK_METHOD2(Overloaded, int(char x, int y));

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(OptionalMatchersHelper);
OptionalMatchersHelper(const OptionalMatchersHelper&) = delete;
OptionalMatchersHelper& operator=(const OptionalMatchersHelper&) = delete;
};

TEST(AllArgsTest, WorksWithoutMatchers) {
Expand Down
3 changes: 2 additions & 1 deletion googlemock/test/gmock-matchers-comparisons_test.cc
Expand Up @@ -579,7 +579,8 @@ class Base {
Base() {}

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(Base);
Base(const Base&) = delete;
Base& operator=(const Base&) = delete;
};

class Derived : public Base {
Expand Down
8 changes: 6 additions & 2 deletions googlemock/test/gmock-matchers-containers_test.cc
Expand Up @@ -342,7 +342,8 @@ class Uncopyable {

private:
int value_;
GTEST_DISALLOW_COPY_AND_ASSIGN_(Uncopyable);
Uncopyable(const Uncopyable&) = delete;
Uncopyable& operator=(const Uncopyable&) = delete;
};

// Returns true if and only if x.value() is positive.
Expand Down Expand Up @@ -2764,7 +2765,10 @@ class NativeArrayPassedAsPointerAndSize {
MOCK_METHOD(void, Helper, (int* array, int size));

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(NativeArrayPassedAsPointerAndSize);
NativeArrayPassedAsPointerAndSize(const NativeArrayPassedAsPointerAndSize&) =
delete;
NativeArrayPassedAsPointerAndSize& operator=(
const NativeArrayPassedAsPointerAndSize&) = delete;
};

TEST(ElementsAreTest, WorksWithNativeArrayPassedAsPointerAndSize) {
Expand Down
3 changes: 2 additions & 1 deletion googlemock/test/gmock-matchers-misc_test.cc
Expand Up @@ -106,7 +106,8 @@ class NotCopyable {
private:
int value_;

GTEST_DISALLOW_COPY_AND_ASSIGN_(NotCopyable);
NotCopyable(const NotCopyable&) = delete;
NotCopyable& operator=(const NotCopyable&) = delete;
};

TEST(ByRefTest, AllowsNotCopyableConstValueInMatchers) {
Expand Down
9 changes: 6 additions & 3 deletions googlemock/test/gmock-nice-strict_test.cc
Expand Up @@ -45,7 +45,8 @@ class Mock {
MOCK_METHOD0(DoThis, void());

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(Mock);
Mock(const Mock&) = delete;
Mock& operator=(const Mock&) = delete;
};

namespace testing {
Expand Down Expand Up @@ -93,7 +94,8 @@ class MockFoo : public Foo {
MOCK_METHOD0(ReturnNonDefaultConstructible, NotDefaultConstructible());

private:
GTEST_DISALLOW_COPY_AND_ASSIGN_(MockFoo);
MockFoo(const MockFoo&) = delete;
MockFoo& operator=(const MockFoo&) = delete;
};

class MockBar {
Expand All @@ -117,7 +119,8 @@ class MockBar {
private:
std::string str_;

GTEST_DISALLOW_COPY_AND_ASSIGN_(MockBar);
MockBar(const MockBar&) = delete;
MockBar& operator=(const MockBar&) = delete;
};

class MockBaz {
Expand Down

0 comments on commit bf66935

Please sign in to comment.