build fails for clang with -Werror

[leissa]

error: missing field 'owner_' initializer [-Werror,-Wmissing-field-initializers]
GTEST_API_ GTEST_DEFINE_STATIC_MUTEX_(g_linked_ptr_mutex);
           ^
/home/roland/projects/thorin2/build_clang/googletest-src/googletest/include/gtest/internal/gtest-port.h:2102:80: note: expanded from macro 'GTEST_DEFINE_STATIC_MUTEX_'
     ::testing::internal::MutexBase mutex = { PTHREAD_MUTEX_INITIALIZER, false }

This regression must be introduced by one quite recent commit.

clang --version
clang version 6.0.0 (tags/RELEASE_600/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

Same error using clang 5.0.0.

Removing -Werror fixes the build. However, I'd like to compile my projects with

-Wall -Wextra -Werror

[leissa]

include/gtest/internal/gtest-port.h:

// Defines and statically (i.e. at link time) initializes a static mutex.
// The initialization list here does not explicitly initialize each field,
// instead relying on default initialization for the unspecified fields. In
// particular, the owner_ field (a pthread_t) is not explicitly initialized.
// This allows initialization to work whether pthread_t is a scalar or struct.
// The flag -Wmissing-field-initializers must not be specified for this to work.
#  define GTEST_DEFINE_STATIC_MUTEX_(mutex) \
     ::testing::internal::MutexBase mutex = { PTHREAD_MUTEX_INITIALIZER, false }

I don't get the comment. What's wrong with adding phthread_t()? It also works in the case that pthread_t is a scalar. Doing something like int() is just fine.

[henryiii]

A fix was added in #633 (which I think is in 1.8.0), but somehow the current master seems to be missing this patch, causing a warning (or in the above case, error) again.

[chadbrewbaker]

Master still isn't fixed. Made the change here and it worked:

https://github.com/google/googletest/pull/633/files#diff-f21e2c91878df000cc7b8b316a89565c

[gennadiycivil]

#1646 addressed that slightly differently

[gennadiycivil]

@leissa is this still an issue?

[leissa]

Works for me now. Thanks :)