Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Matcher documentation #2463

Closed
cfsteefel opened this issue Sep 18, 2019 · 2 comments
Closed

Missing Matcher documentation #2463

cfsteefel opened this issue Sep 18, 2019 · 2 comments
Assignees

Comments

@cfsteefel
Copy link

In both the gMock and gtest documentations, a set of Matchers is described, and links are provided that suggest they should go to a complete listing of the Matchers. However, both just link back to the gMock cookbook itself.
The gMock link is located in the first line under the heading here: https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#using-predicates-as-matchers
The gtest link can be seen here, described as a list of all matchers:
https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#asserting-using-gmock-matchers
The bad link can be seen here: https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#MatcherList

Would it be possible to update these links to either point to the correct location (if it exists), or delete them?

@CJ-Johnson
Copy link
Contributor

Thank you for the issue! This has now been addressed internally and will be fixed in the next OSS push. (333288356)

vslashg pushed a commit that referenced this issue Sep 23, 2020
Address OSS Issue #2463 #2463

PiperOrigin-RevId: 333289989
@ybgunjal2000
Copy link

ybgunjal2000 commented Sep 24, 2020 via email

vslashg pushed a commit that referenced this issue Sep 24, 2020
Address OSS Issue #2463 #2463

PiperOrigin-RevId: 333289989
vslashg pushed a commit that referenced this issue Sep 24, 2020
Address OSS Issue #2463 #2463

PiperOrigin-RevId: 333289989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants