-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions about Abseil as dependency of googletest #2883
Comments
The plans aren't finalized and I don't know when we will get to this. As background information, Abseil was created because at Google we have a large monorepo of code, and Abseil is the common code that a lot of other code, including GoogleTest, depends on. When GoogleTest was open-sourced, a lot of that common code was forked because Abseil didn't exist. One reason for doing this is to get rid of the forked code. We've actually had an optional implementation of this for a while. Lines 44 to 47 in c6e309b
If you use Bazel, you can add --define=absl=1 to see how this might work. Really what we are talking about is removing the optional code path, because maintaining compile options is somewhat expensive in terms of testing cost.
It will be visible though public headers.
It won't be bundled. This would be potentially create diamond dependencies for other Abseil users.
You would need a compatible version of Abseil. In practice we expect this to be a non-issue if you follow our recommendations to upgrade often. Let us know if you have concerns. |
Thank you for clarification. I asked out of curiosity and have no concerns with that solution. I'm writing software for embedded linux devices using the PTXdist build system (similar to Yocto, which might be more popular). In order to have tests which are executed on the target device, googletest is used. Since PTXdist manages dependencies via it's own recipe-based mechanism, I'm always curious about dependencies of basic software packages. Therefore, your intendet solution to have Abseil as a separate package suits very well, especially when it is visible through public headers. In this case, I can add a recipe for Abseil and make it a dependency of my googletest recipe and everything is fine. Thank you very much. |
I've read that you plan to take a dependency on Abseil and I wonder what this exactly means for the users of googletest.
The text was updated successfully, but these errors were encountered: