-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'master' tag missing from github breaking cmake builds #3663
Comments
apparently google has dropped the master tag, main now works: google/googletest#3663
Wow wonder how many repos that broke ... |
Thanks for the fast issue description and proposed fix! Wanted to report it myself after my CI build broke. Great community here 👍 |
Maybe makes sense to update the readme. It still refers to |
@Bam4d , Any reason you don't apply the suggested fix? (change GIT_TAG)? or do i miss something as a brand new user? |
@assafpr It's totally fine to just change the tag (I did this in my own projects). I made the bug report because I imagined many people would run into this issue and wanted to show that the fix was quick and easy :) |
@Bam4d , I'll try to push it to the origin repository if it is OK with you (it is your fix after all) and if @j-blue-arz is not going to try and push the fix he did in j-blue-arz/labyrinth@8806f07 . |
@assafpr There is nothing to push. The fix I made was for my own repo. As I see it, there are only two options here:
Edit: an older version of the tutorial I mentioned apparently did not use |
This change makes it impossible to recreate former versions of all clients which use this repo - not really the basic idea of source code repository. |
Issue: google/googletest#3663 Change-Id: I1379f39e180869ef25d4d5f8e5963baa1f7e432e Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/14681 Tested-by: gerrit-photon <photon-checkins@vmware.com> Reviewed-by: Shreenidhi Shedi <sshedi@vmware.com>
…aster to main. (see google/googletest#3663 )
Hii , Regards |
You might need to do a clean of your test build folder as well (I think I've seen this issue and this worked for me) |
- the default branch name is now "main"; see google/googletest#3663
…TAG to reflect this change, see github.com/google/googletest/issues/3663
Maintainers changed branch to `main` Reference: google/googletest#3663
I've just spotted that warning messages and tests were not updated and still point to the now non-existant master branch. See for example: |
@WysokiStudent thanks, I've added PR #3918 |
if you guys can like not break things unnecessarily that'd be great thanks |
I am using gtest_force_shared_crt, and when using CMake with the "master" branch, it is generating automatically. How can I fix this issue? |
Describe the bug
It looks like the "master" tag has been dropped, so all builds that use cmake to clone the repositories are breaking if they use the "master" tag.
Its an easy fix (change
master
tomain
) but this bug will probably help other people that run into this issue.Steps to reproduce the bug
using the standard cmake builder for googletest:
As soon as i try to build my project the above cmake error occurs.
What operating system and version are you using?
Ubuntu Linux 20.04
What build system are you using?
cmake version 3.21.2
Additional context
Change GIT_TAG to 'main' the problem fixes itself.
The text was updated successfully, but these errors were encountered: