Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tmux / tmux-256color to the list of TERMs with color #698

Closed
achimnol opened this issue Jan 31, 2016 · 1 comment
Closed

Add tmux / tmux-256color to the list of TERMs with color #698

achimnol opened this issue Jan 31, 2016 · 1 comment

Comments

@achimnol
Copy link
Contributor

https://github.com/google/googletest/blob/82b11b8/googletest/src/gtest.cc#L2927-L2936
The above lines of code are defining the list of known-good terminals for colored output.

I would suggest to add "tmux" and "tmux-256color", as tmux v2.1 (latest at the time of writing) now enforces screen-compatible behavior (e.g., altering italics) and suggests to use "tmux" and "tmux-256color" terminals for those who want such extra customizations. Moreover, some Linux distros such as ArchLinux contain these terminals by default, and I see no reason why there is only screen but tmux. ;)

@BillyDonahue
Copy link
Contributor

Sounds good. Can you send a PR for that?

On Sun, Jan 31, 2016 at 1:36 AM, Joongi Kim notifications@github.com
wrote:

https://github.com/google/googletest/blob/82b11b8/googletest/src/gtest.cc#L2927-L2936
The above lines of code are defining the list of known-good terminals for
colored output.

I would suggest to add "tmux" and "tmux-256color", as tmux v2.1 (latest at
the time of writing) now enforces screen-compatible behavior (e.g.,
altering italics) and suggests to use "tmux" and "tmux-256color" terminals
for those who want such extra customizations. Moreover, some Linux distros
such as ArchLinux contain these terminals by default, and I see no reason
why there is only screen and not tmux. ;)


Reply to this email directly or view it on GitHub
#698.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants