New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting in primer.md #2341
Formatting in primer.md #2341
Conversation
This formatting is dictated by internal formatters and does not seem to cause any issues. What is the motivation to change it? |
Hi @gennadiycivil |
Hi all, |
That's fine by me, but will be a couple of days before I have a chance.
Chris
…On 30 July 2019 09:47:20 BST, kuzkry ***@***.***> wrote:
Hi all,
@gennadiycivil, I can confirm @ChrisBaish is right.
@ChrisBaish, the same formatting problems can be found in tables in
[CheatSheet](https://github.com/google/googletest/blob/c205468b65a5b6f3239c4e68af860f6c82895f9d/googlemock/docs/cheat_sheet.md),
[CookBook](https://github.com/google/googletest/blob/c205468b65a5b6f3239c4e68af860f6c82895f9d/googlemock/docs/cook_book.md)
and
[Advanced](https://github.com/google/googletest/blob/c205468b65a5b6f3239c4e68af860f6c82895f9d/googletest/docs/advanced.md).
Would you mind to extend your PR to fix them too (though you would have
to change the title as well)?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#2341 (comment)
|
PiperOrigin-RevId: 261344735
Fixes #2340