Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting in primer.md #2341

Merged
merged 4 commits into from Aug 2, 2019
Merged

Formatting in primer.md #2341

merged 4 commits into from Aug 2, 2019

Conversation

RosieBaish
Copy link
Contributor

Fixes #2340

@gennadiycivil
Copy link
Contributor

This formatting is dictated by internal formatters and does not seem to cause any issues. What is the motivation to change it?

@gennadiycivil
Copy link
Contributor

@ChrisBaish

@RosieBaish
Copy link
Contributor Author

Hi @gennadiycivil
When I viewed the page on github the rendering was unreadable.
It didn't accept the : characters as valid line breaks, so would put : code : code : code : all in the first cell, and nothing in the others.
After changing, it rendered properly.
I've attached before and after screenshots, both taken on Ubuntu 18 with Chrome. (Not that it should matter)
Before:
before
After:
after

@kuzkry
Copy link
Contributor

kuzkry commented Jul 30, 2019

Hi all,
@gennadiycivil, I can confirm @ChrisBaish is right.
@ChrisBaish, the same formatting problems can be found in tables in CheatSheet, CookBook and Advanced. Would you mind to extend your PR to fix them too (though you would have to change the title as well)?

@RosieBaish
Copy link
Contributor Author

RosieBaish commented Jul 30, 2019 via email

@guillemglez
Copy link
Contributor

Just fixed tables in advanced in PR #2361

@gennadiycivil gennadiycivil merged commit 3525e39 into google:master Aug 2, 2019
gennadiycivil added a commit that referenced this pull request Aug 2, 2019
PiperOrigin-RevId: 261344735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table formatting in primer.md
6 participants