Fix FlatTuple compilation on older msvc. #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googletest 1.10.0 fails to compile on msvc version 19.00.23917 with one compilation error: src\googletest\include\gtest\internal\gtest-internal.h(1188) : error C2039: 'FlatTupleBase<testing::internal::FlatTuple<bool,bool>,testing::internal::IndexSequence<0,1> >': is not a member of 'testing::internal::FlatTuple<bool,bool>' This PR fixes the compilation error by explicitly specifying the full type that Indices is located in the base type.
jaykrell
reviewed
Nov 16, 2019
| @@ -1185,7 +1185,7 @@ struct FlatTupleBase<FlatTuple<T...>, IndexSequence<Idx...>> | |||
|
|
|||
| // Analog to std::tuple but with different tradeoffs. | |||
| // This class minimizes the template instantiation depth, thus allowing more | |||
| // elements that std::tuple would. std::tuple has been seen to require an | |||
| // elements than std::tuple would. std::tuple has been seen to require an | |||
| // instantiation depth of more than 10x the number of elements in some | |||
| // implementations. | |||
| // FlatTuple and ElemFromList are not recursive and have a fixed depth | |||
There was a problem hiding this comment.
"it is" a few lines below should be "is".
"ln" after that should probably be "lg". i.e. log base 2 instead of log base e. Just guessing.
jaykrell
approved these changes
Nov 16, 2019
|
@bgianfo Thank you for the patch. Could you please explain exactly what version of Visual Studio, etc this is? |
|
@gennadiycivil The MSVC compiler I was using is from Visual Studio 2015, version 14.0. https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B I didn't do an exhaustive test to see at which MSVC version master starts building clean. |
|
Thank you, we have started internal review. Please don't push any more changes into this PR as they might be overwritten. |
gennadiycivil
added a commit
that referenced
this pull request
Nov 19, 2019
PiperOrigin-RevId: 281321427
gennadiycivil
added a commit
that referenced
this pull request
Nov 20, 2019
PiperOrigin-RevId: 281321427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
googletest 1.10.0 fails to compile on msvc version 19.00.23917
with one compilation error:
src\googletest\include\gtest\internal\gtest-internal.h(1188) : error C2039:
'FlatTupleBase<testing::internal::FlatTuple<bool,bool>,testing::internal::IndexSequence<0,1> >':
is not a member of 'testing::internal::FlatTuple<bool,bool>'
This PR fixes the compilation error by explicitly specifying the full type that Indices is
located in the base type.