Fixed issue #823. Fixed feature detection bugs. #827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BillyDonahue This PR eliminates the AppVeyor complains. Now the CI works like a charm. Please check :) |
|
Related to issue #823 |
|
Hi @BillyDonahue , could you please check if this PR can be merged? The AppVeyor check failure may confusing the PR authors. And this PR just fixed the bug which causes AppVeyor check failure. |
|
Hi @mazong1123. I already have long running PR #811 for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check the value of _MSC_VER besides its existence for several scenarios. Including hash_map, hash_set and throwing exceptions in destructors. This PR eliminates the AppVeyor complains which caused by the lack of _MSV_VER value checking.