Implement RMCP layer type #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notti
requested changes
May 17, 2019
> Byte slices returned by PrependBytes/AppendBytes are NOT zero'd > out, so if you want to make sure they're all zeros, set them as > such.
|
I'm not sure why the Windows build failed... could you hit restart? |
notti
approved these changes
May 20, 2019
|
I'm also not sure what happened here. Travis is somehow not as reliable as I wish it would be. |
|
Thanks for the implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the RMCP header, specified in section 3.2.2.2 of ASF v2.0. I plan to implement the ASF (inner) layer very soon in another MR.
Passes
./gc; any feedback much appreciated!