Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Path to DeviceDesc #101

Merged
merged 7 commits into from
Nov 10, 2021
Merged

Add Path to DeviceDesc #101

merged 7 commits into from
Nov 10, 2021

Conversation

willmcenaney
Copy link
Contributor

@willmcenaney willmcenaney commented Oct 20, 2021 •
edited
Loading

See #28.

Implemented Path as part of getDeviceDesc as suggested.
Appended port to path to give complete device port path (except for bus number). This gives a consistent result with its name in context and with comparable usb library in python.

@willmcenaney
Copy link
Contributor Author

Hey @zagrodzki could you review(&hopefully merge) when you get chance?
Is there a standard release cycle?

zagrodzki
zagrodzki requested changes Nov 1, 2021
View reviewed changes
libusb.go Outdated Show resolved Hide resolved
libusb.go Outdated Show resolved Hide resolved
device.go Outdated Show resolved Hide resolved
libusb.go Outdated Show resolved Hide resolved
@willmcenaney
Fixes:
ca7ce37 
Standardisation of variables
Deduplication of C calls
Improved documentation of DevicePath
zagrodzki
zagrodzki requested changes Nov 3, 2021
View reviewed changes
device.go Outdated Show resolved Hide resolved
libusb.go Outdated Show resolved Hide resolved
libusb.go Outdated Show resolved Hide resolved
libusb.go Outdated Show resolved Hide resolved
libusb.go Outdated Show resolved Hide resolved
libusb.go Outdated Show resolved Hide resolved
device.go Outdated Show resolved Hide resolved
@willmcenaney
Rationalise port selection for root devices
dbce926 
Rationalise DevicePath type to []int
Update comments accordingly
willmcenaney
willmcenaney commented Nov 4, 2021
View reviewed changes
Copy link
Contributor Author

@willmcenaney willmcenaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only thing outstanding is the comments on Path.
The whole pathLen debacle has ended up being quite elegant by flipping it around and using the default cases.

device.go Outdated Show resolved Hide resolved
zagrodzki
zagrodzki requested changes Nov 4, 2021
View reviewed changes
device.go Outdated Show resolved Hide resolved
libusb.go Outdated Show resolved Hide resolved
device.go Outdated Show resolved Hide resolved
device.go Outdated Show resolved Hide resolved
@zagrodzki zagrodzki merged commit 6ad122d into google:master Nov 10, 2021
@willmcenaney
Copy link
Contributor Author

Thanks for all your help @zagrodzki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zagrodzki zagrodzki Awaiting requested review from zagrodzki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willmcenaney @zagrodzki