Fix a race condition in reuse of the same malloc result #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a new buffer() call to get access to the allocated buffer as a Go slice.
endpoint.transfer.
itself is released. That ensures that a concurrent alloc() will not try to insert the same pointer into the map that was not yet removed.
|
I think I broke the commit by reusing an unsynced branch... let me try again... |
|
There, better now. |
|
Looks good, but I think it’d be cleaner for the git history if you rebased your change onto the master branch (instead of merging master into your branch). See https://manpages.debian.org/stretch/git-man/git-rebase.1.en.html |
stapelberg
approved these changes
Sep 4, 2017
|
Noted. It won't matter after a squashed commit though. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12