Merge pull request #313 from google/more_analysis

fix a few analysis issues

.analysis_options

@@ -0,0 +1,2 @@
+analyzer:
+  # strong-mode: true

lib/grinder.dart

@@ -49,9 +49,9 @@ Future grind(List<String> args, {bool verifyProjectRoot: true}) {
   } catch (e) {
     if (e is GrinderException) {
       fail(e.message);
-    } else {
-      return new Future.error(e);
     }
+
+    return new Future.error(e);
   }
 }
 

lib/src/cli.dart

@@ -4,7 +4,7 @@
 library grinder.src.cli;
 
 import 'dart:async';
-import 'dart:convert' show JSON, UTF8;
+import 'dart:convert' show JSON;
 
 import 'package:unscripted/unscripted.dart';
 
@@ -14,7 +14,7 @@ import 'singleton.dart' as singleton;
 import 'utils.dart';
 
 // This version must be updated in tandem with the pubspec version.
-const String appVersion = '0.8.0+2';
+const String appVersion = '0.8.0+3';
 
 List<String> grinderArgs() => _args;
 List<String> _args;
@@ -92,8 +92,6 @@ cli(@Rest(
       fail(message);
     });
   }
-
-  return new Future.value();
 }
 
 Script script = new Script(cli);

test/grinder_sdk_test.dart

@@ -18,20 +18,14 @@ main() {
       }
     });
 
-    test('getSdkDir', () {
-      expect(getSdkDir(), isNotNull);
-      expect(getSdkDir(grinderArgs()), isNotNull);
-      expect(getSdkDir([]), isNotNull);
+    test('sdkDir', () {
+      expect(sdkDir, isNotNull);
     });
 
     test('get dartVM', () {
       expect(dartVM, isNotNull);
     });
 
-//    test('DartSdk.location', () {
-//      expect(DartSdk.location, isNotNull);
-//    });
-
     test('Dart.version', () {
       expect(Dart.version(quiet: true), isNotEmpty);
     });