Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should throw some kind of error when DART_SDK is not defined. #13

Closed
digitalfiz opened this issue Jul 7, 2014 · 3 comments
Closed

Should throw some kind of error when DART_SDK is not defined. #13

digitalfiz opened this issue Jul 7, 2014 · 3 comments

Comments

@digitalfiz
Copy link

Since this package depends on $DART_SDK to be set it should throw an error when its not.

@devoncarew
Copy link
Contributor

Hmm, some of the tasks require locating an SDK; some tasks would not. And we try and locate an SDK even in the absence of the DART_SDK env variable.

Perhaps a utility method would be in order, to throw if a dart SDK can't be located? Scripts would need to call that in their init phase if they depended on tasks that require an SDK.

@digitalfiz
Copy link
Author

Sounds good to me :-D

It was frustrating trying to figure out why I was getting errors about path method not found. Actually found the solution on another projects issues tab so I thought I would relay it here.

@devoncarew
Copy link
Contributor

We added support for this in 0.5.7 - tasks which require an sdk now throw if one is not present. Thanks for the report!

jcollins-g pushed a commit to jcollins-g/grinder.dart that referenced this issue Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants